Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): fix issues visual issues with dark theme #457

Merged
merged 2 commits into from
Jul 8, 2023

Conversation

SethFalco
Copy link
Member

@SethFalco SethFalco commented Jul 8, 2023

  • Make the error message UI use the secondary background color defined by our theme.
    • This fixes the theme on dark mode.
    • This changes the color in light mode to use the same color as the text areas and file upload UI.
    • UI looks more consistent with other components.

My previous PR introduced the other issues. Sorry, I should QA better. ^-^'

  • Fixed a bug where the textareas had black text on dark mode. It's now white on dark mode like before.
  • Fixed a bug where the language selection didn't apply the correct background color on dark theme.

Screenshots

Before (libretranslate.com)

image

After

image

Reference:

@pierotofy
Copy link
Member

Thanks for the fix! I should have tested more thoroughly as well ^_^

@pierotofy pierotofy merged commit 9052265 into LibreTranslate:main Jul 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants