Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive tab only displays games from the library location set as default. #928

Open
knikki opened this issue Feb 20, 2018 · 17 comments
Open
Milestone

Comments

@knikki
Copy link

knikki commented Feb 20, 2018

This took me weeks to figure out, but I've done some testing and finally narrowed down why my Revive tab only displayed Dreamdeck, Touch Basics, First Contact, and Avatars. This is not a duplicate of the other issue that someone made 20 days ago.

oculus

With the recent update to the Oculus app that allows for installing games to another location, I added D:\Games\Oculus as a second library location and set it as default. Only the four experiences listed above were displayed in Revive. Once C:\Program Files\Oculus\Software was made the default again, my entire Oculus library shows up in Revive.

I'd like to be able to set other locations as the default and keep them default, and still have Revive recognize the games I have installed in the first location, since both are listed in Library Locations. Super happy to have figured out the issue, but thought you might like a note of it here so that multiple locations can be supported by Revive in the future. Thanks!

@CrossVR
Copy link
Member

CrossVR commented Feb 20, 2018

This was mentioned in the changelist for version 1.2.1, but I definitely should've mentioned it more prominently:

This release fixes Oculus library scanning for the new Core 2.0 release. Please note that Revive only supports scanning your default library right now, support for multiple libraries will come in a later version.

@CrossVR CrossVR added this to the 1.3.0 milestone Feb 20, 2018
@CrossVR
Copy link
Member

CrossVR commented Feb 20, 2018

Thanks for the feedback though, now I know there are Revive users who make use of this new Oculus Home feature, so I'll move it up on my priority list.

@knikki
Copy link
Author

knikki commented Feb 20, 2018

Thanks for commenting! I skimmed the changelog when it went live and must have just glanced right over that part. I'm glad to hear you're aware, and appreciate you moving it up the list. :)

@rxstud2011
Copy link

I had the same issue, thank you!

@saitoh183
Copy link

This issue stilll exist in the current version of Revive

@drowhunter
Copy link

Was this fixed because its still happening to me and its almost 2020

@CrossVR
Copy link
Member

CrossVR commented Dec 23, 2019

This is not yet fixed, but I'm planning to work on it soon.

As you might have noticed other issues had higher priority than this and no one else was interested in resolving the issue so far. (You're welcome to help resolve it if you're familiar with C++ and Qt)

@croger42
Copy link
Contributor

croger42 commented Jan 2, 2020

Hi. I have the same problem and I checked revive source code...
Not so easy: it seems changes have to be made in reviveOverlay (and reviveInjector ?). And manifest files may be impacted (not sure yet). I have started some enhancement but I can't say if it will work soon. Or Never.

@CrossVR
Copy link
Member

CrossVR commented Jan 2, 2020

I'm currently rewriting the injector an will be keeping support for multiple libraries in mind. The overlay will be the real difficulty.

@croger42
Copy link
Contributor

croger42 commented Jan 5, 2020

Hello.
Overlay changes are almost done.
I will test them, push it on my fork, and send a pull request.
There is a change in the injector, (it needs to read a new parameter). If you are rewriting the injector, I don't know if I put it in the pull request.
A last thing: for now, changes permit only to have 3 different folders. Because folders are declared in qml file and I don't know QT at all !

@CrossVR
Copy link
Member

CrossVR commented Jan 5, 2020

That's great news! I'm very interested to see your solution. I assume the limit of 3 libraries is due to adding 3 folder models to the QML?

My original idea was to add a library selection UI to the dashboard that changes the folder on one model. But your idea would be a good solution for the time being, we'll see if it becomes necessary to support more libraries.

I'll focus on rewriting the injector and adding support for multiple libraries there. I can take your changes into account and make some improvements to it if necessary, so feel free to include those changes in your PR.

@croger42
Copy link
Contributor

croger42 commented Jan 7, 2020

Yes, limit is due to folder models. I will check this later.
I had some tests problems yesterday launching apps through openvr (and with the installer too). One problem is still remaining: Overlay app can't write manifest file in the"program files" folder (not a big deal I think). I hope I can commit this evening (in my timezone...)

@CrossVR
Copy link
Member

CrossVR commented Jan 7, 2020

The manifest file is important though, but I can take a look at any problems with it once you post your PR.

croger42 added a commit to croger42/Revive that referenced this issue Jan 7, 2020
@croger42
Copy link
Contributor

croger42 commented Jan 7, 2020

So, the problem with the revive manfest file was a write permission issue. I think I had a problem with the nsis installer.
First commit is for overlay, second one for injector. And some code needs to be cleaned.
What is working: games from both libraries are displayed in revive Overlay and launch is OK...
Not working: Support games fail to launch (Dreamdeck...): I missed something in the injector.

croger42 added a commit to croger42/Revive that referenced this issue Jan 8, 2020
@CrossVR
Copy link
Member

CrossVR commented Jan 12, 2020

@croger42 Are you planning to submit a PR for it?

@croger42
Copy link
Contributor

Hello, yes, i will do it. From my fork to your master or another branch ?

@CrossVR
Copy link
Member

CrossVR commented Jan 14, 2020

To master is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants