Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvisual-plugins: Base rotation on runtime not FPS for actor "lv_gltest" #163

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

hartwork
Copy link
Member

@hartwork hartwork commented Jan 13, 2023

Similar to pull request #153 and #164 but for master.

@hartwork hartwork added this to the 0.5.0 milestone Jan 13, 2023
Copy link
Member

@kaixiong kaixiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

@kaixiong
Copy link
Member

Wait.. I think the timer needs to be destroyed with visual_timer_free().

@hartwork
Copy link
Member Author

Wait.. I think the timer needs to be destroyed with visual_timer_free().

@kaixiong good catch! Added now and also backported to 0.4.x in pull request #164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants