Switch Automation to Chrome for Test Speed

Lidarr · Oct 14, 2020 · 0e78135 · 0e78135
1 parent e836b79
commit 0e78135
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 6 deletions.
diff --git a/frontend/src/Components/Loading/LoadingIndicator.js b/frontend/src/Components/Loading/LoadingIndicator.js
@@ -1,3 +1,4 @@
+import classNames from 'classnames';
 import PropTypes from 'prop-types';
 import React from 'react';
 import styles from './LoadingIndicator.css';
@@ -13,7 +14,7 @@ function LoadingIndicator({ className, rippleClassName, size }) {
       style={{ height }}
     >
       <div
-        className={styles.rippleContainer}
+        className={classNames(styles.rippleContainer, 'followingBalls')}
         style={{ width, height }}
       >
         <div

diff --git a/src/NzbDrone.Automation.Test/AutomationTest.cs b/src/NzbDrone.Automation.Test/AutomationTest.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using FluentAssertions;
@@ -9,7 +10,7 @@
 using NzbDrone.Common.EnvironmentInfo;
 using NzbDrone.Test.Common;
 using OpenQA.Selenium;
-using OpenQA.Selenium.Firefox;
+using OpenQA.Selenium.Chrome;
 using OpenQA.Selenium.Remote;
 
 namespace NzbDrone.Automation.Test
@@ -34,9 +35,12 @@ public AutomationTest()
         [OneTimeSetUp]
         public void SmokeTestSetup()
         {
-            var options = new FirefoxOptions();
+            var options = new ChromeOptions();
             options.AddArguments("--headless");
-            driver = new FirefoxDriver(options);
+            var service = ChromeDriverService.CreateDefaultService();
+
+            // Timeout as windows automation tests seem to take alot longer to get going
+            driver = new ChromeDriver(service, options, new TimeSpan(0, 3, 0));
 
             _runner = new NzbDroneRunner(LogManager.GetCurrentClassLogger());
             _runner.KillAll();

diff --git a/src/NzbDrone.Automation.Test/Lidarr.Automation.Test.csproj b/src/NzbDrone.Automation.Test/Lidarr.Automation.Test.csproj
@@ -7,8 +7,8 @@
     <PackageReference Include="NUnit" Version="3.12.0" />
     <PackageReference Include="NUnit3TestAdapter" Version="3.16.1" />
     <PackageReference Include="NunitXml.TestLogger" Version="2.1.41" />
-    <PackageReference Include="Selenium.Firefox.WebDriver" Version="0.26.0" />
     <PackageReference Include="Selenium.Support" Version="3.141.0" />
+    <PackageReference Include="Selenium.WebDriver.ChromeDriver" Version="84.0.4147.3001" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\NzbDrone.Test.Common\Lidarr.Test.Common.csproj" />

diff --git a/src/NzbDrone.Automation.Test/PageModel/PageBase.cs b/src/NzbDrone.Automation.Test/PageModel/PageBase.cs
@@ -37,7 +37,7 @@ public void WaitForNoSpinner(int timeout = 30)
             {
                 try
                 {
-                    IWebElement element = d.FindElement(By.Id("followingBalls"));
+                    IWebElement element = d.FindElement(By.ClassName("followingBalls"));
                     return !element.Displayed;
                 }
                 catch (NoSuchElementException)