Fixed: Make ProcessProviderTests less flaky

Lidarr · Aug 24, 2019 · 1a0b95d · 1a0b95d
1 parent ee7d47d
commit 1a0b95d
Showing 1 changed file with 35 additions and 2 deletions.
diff --git a/src/NzbDrone.Common.Test/ProcessProviderTests.cs b/src/NzbDrone.Common.Test/ProcessProviderTests.cs
@@ -3,6 +3,7 @@
 using System.Diagnostics;
 using System.IO;
 using System.Linq;
+using System.Threading;
 using FluentAssertions;
 using NUnit.Framework;
 using NzbDrone.Common.Model;
@@ -12,6 +13,8 @@
 
 namespace NzbDrone.Common.Test
 {
+    // We don't want one tests setup killing processes used in another
+    [NonParallelizable]
     [TestFixture]
     public class ProcessProviderTests : TestBase<ProcessProvider>
     {
@@ -63,9 +66,25 @@ public void GetProcessById_should_return_null_for_invalid_process(int processId)
             ExceptionVerification.ExpectedWarns(1);
         }
 
+        [Test]
+        public void should_be_able_to_start_process()
+        {
+            var process = StartDummyProcess();
+
+            var check = Subject.GetProcessById(process.Id);
+            check.Should().NotBeNull();
+
+            process.Refresh();
+            process.HasExited.Should().BeFalse();
+
+            process.Kill();
+            process.WaitForExit();
+            process.HasExited.Should().BeTrue();
+        }
+
         [Test]
         [Platform(Exclude="MacOsX")]
-        public void Should_be_able_to_start_process()
+        public void exists_should_find_running_process()
         {
             var process = StartDummyProcess();
 
@@ -94,8 +113,22 @@ public void kill_all_should_kill_all_process_with_name()
 
         private Process StartDummyProcess()
         {
+            var processStarted = new ManualResetEventSlim();
+
             var path = Path.Combine(TestContext.CurrentContext.TestDirectory, DummyApp.DUMMY_PROCCESS_NAME + ".exe");
-            return Subject.Start(path);
+            var process = Subject.Start(path, onOutputDataReceived: (string data) => {
+                    if (data.StartsWith("Dummy process. ID:"))
+                    {
+                        processStarted.Set();
+                    }
+                });
+
+            if (!processStarted.Wait(2000))
+            {
+                Assert.Fail("Failed to start process within 2 sec");
+            }
+
+            return process;
         }
 
         [Test]