week23 finished #27
Merged
week23 finished #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aszx87410
reviewed
Dec 11, 2021
| border: 1px solid ${(props) => props.theme.colors.border}; | ||
| ` | ||
|
|
||
| function AddInput({ type, placeholder, value, onChange, onKeyPress }) { |
There was a problem hiding this comment.
如果你這個 component 只是把東西都傳下去，其實不需要這個，你直接用 AddInputStyle 也可以達成一樣的效果
aszx87410
reviewed
Dec 11, 2021
| margin-bottom: 20px; | ||
| ` | ||
|
|
||
| const DeleteAllButtonStyle = styled(SmallButtonStyle)` |
There was a problem hiding this comment.
你底下這些其實都可以用同一個 button，加上 css & + & { margin-left: 8px} 就好
|
Redux 的基本使用看起來沒什麼問題，其他部分就是有些小細節可以注意一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redux_TodoList 連結
完成功能如下:
到最後一個禮拜了，雖然只完成到 week23 的 redux 作業，感謝老師助教的批改，謝謝!!