Return a Try[JsObject] for fromDynamoJson (reads) #1
Conversation
A JsObject passed into the converter may throw an match exception because the object was:
1) not actually a dynamoDB JsObject
2.) Has some unsupported types on it that we don't currently support (i.e. Binary ("B") or BinarySet ("BS"))
|
I would recommend something more concrete about the returned failure type than what you get with Try. Or or Either would be much better. |
|
Hmm, I'm not sure what I would put in the response? The exception is a match error on the Json because the json wasn't actually dynamo formatted Json. I guess the match error itself would be useful as it probably contains the exact item that did not match? |
|
http://aboutwhichmorelater.tumblr.com/post/30409572482/scala-util-try Try is a just a pretty awful type. It would be better to create a real failure type with the information you want to get at clearly encoded. Or is a much better monadic structure for the return type and would allow you to map over every error - not just one type of "Throwable" |
|
One thing to consider would be to use Play JSON's validation facility. |
A JsObject passed into the converter may throw an match exception because the object was: