Return a Try[JsObject] for fromDynamoJson (reads)

src/main/scala/com/lifeway/play/dynamo/DynamoJsonConverters.scala

@@ -1,7 +1,9 @@
 package com.lifeway.play.dynamo
 
 import play.api.libs.json._
+
 import scala.collection.GenTraversable
+import scala.util.Try
 
 object DynamoJsonConverters {
 
@@ -47,8 +49,12 @@ object DynamoJsonConverters {
       * Given a JsObject that was stored in DynamoDB, this will turn that Dynamo json into a standard JsObject will all of
       * the dynamo types removed. Typically, you would use this to transform the Dynamo response back to a JsValue type
       * that you could then pass to Play's standard Json writes method.
+      *
+      * Note that this returns a Try[JsObject], because if a non dynamoDB json object is passed to it (which we can't
+      * prevent), or if a currently unsupported DynamoDB type was in the object (i.e. Binary or BinarySet), then we
+      * would throw a match exception.
       */
-    def fromDynamoJson: JsObject = {
+    def fromDynamoJson: Try[JsObject] = {
       def objectConversion(i: JsObject): JsObject =
         JsObject(i.fields.flatMap {
           case (k, JsObject(wrappedObj)) =>
@@ -81,7 +87,7 @@ object DynamoJsonConverters {
             }
         })
 
-      objectConversion(input)
+      Try(objectConversion(input))
     }
   }
 }

src/test/scala/com/lifeway/play/dynamo/JsonToFromDynamoSpec.scala

@@ -4,6 +4,8 @@ import com.lifeway.play.dynamo
 import org.scalatest.{MustMatchers, WordSpec}
 import play.api.libs.json.{JsObject, Json}
 
+import scala.util.Try
+
 class JsonToFromDynamoSpec extends WordSpec with MustMatchers {
 
   case class NestedObject(title: String, age: Byte)
@@ -139,9 +141,24 @@ class JsonToFromDynamoSpec extends WordSpec with MustMatchers {
     "read from DynamoDB Json through direct Json Converters to standard case class readers" in {
       import DynamoJsonConverters.Converters
 
-      println(sampleJson.as[JsObject].fromDynamoJson)
+      val result: Try[TestSample] = sampleJson.as[JsObject].fromDynamoJson.map(_.as[TestSample])
+      result.isSuccess mustEqual true
+      result.get mustEqual sampleVal
+    }
+
+    "read from an invalid DynamoDB JSON through direct Json Converters should return an failed Try in the event of non-dynamo Json" in {
+      import DynamoJsonConverters.Converters
+
+      val json = Json.parse(
+        """
+          |{
+          |   "key": "This is normal Json",
+          |   "otherThing": true
+          |}
+        """.stripMargin)
 
-      sampleJson.as[JsObject].fromDynamoJson.as[TestSample] mustEqual sampleVal
+      val result: Try[TestSample] = json.as[JsObject].fromDynamoJson.map(_.as[TestSample])
+      result.isSuccess mustEqual false
     }
 
     "write to DynamoDB Json through direct Json converters that occur after the standard case class Json writers" in {