Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework for Centrallix tests in C #14

Merged
merged 21 commits into from
Feb 2, 2021
Merged

Framework for Centrallix tests in C #14

merged 21 commits into from
Feb 2, 2021

Conversation

sheesania
Copy link
Contributor

@sheesania sheesania commented Dec 18, 2020 •
edited
Loading

Depends on #15

@sheesania sheesania mentioned this pull request Dec 18, 2020
Open
@sheesania sheesania changed the base branch from master to remove_net_raw December 18, 2020 19:59
@dpulls
Copy link

dpulls bot commented Dec 21, 2020

🎉 All dependencies have been resolved !

gbeeley
gbeeley requested changes Dec 21, 2020
View reviewed changes
Copy link
Member

@gbeeley gbeeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the actual code yet, but is there a reason that this PR wants to merge into remove_net_raw? Just wanted to ensure that wasn't a goof or an artifact of dpulls or whatnot before I started munching my way through this pull request.

Base automatically changed from remove_net_raw to master December 21, 2020 22:08
@sheesania
Copy link
Contributor Author

That's just part of chaining pull requests with dpulls - it means that you should see this branch diffed with remove_net_raw, instead of with master. However, as you can see, once remove_new_raw was merged and the branch deleted, it automatically updated to merge into master instead.

@gbeeley
Copy link
Member

gbeeley commented Dec 21, 2020

Ah, got it. Dpulls just didn't act quite quickly enough to update this PR. :)

@sheesania
Copy link
Contributor Author

Actually the issue was that I had to go and manually delete the branch after it was merged, since GitHub doesn't delete it automatically - you still have to click the button!

gbeeley
gbeeley requested changes Dec 21, 2020
View reviewed changes
Copy link
Member

@gbeeley gbeeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

centrallix/Makefile.in Outdated Show resolved Hide resolved
centrallix/tests/t_driver.c Outdated Show resolved Hide resolved
centrallix/tests/t_driver.c Outdated Show resolved Hide resolved
centrallix/tests/test_00baseline_05.c Show resolved Hide resolved
This was referenced Jan 29, 2021
Closed
Merged
gbeeley
gbeeley approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@gbeeley gbeeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks! :)

@gbeeley gbeeley merged commit e206e04 into master Feb 2, 2021
@sheesania sheesania deleted the testing-framework branch February 2, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbeeley gbeeley gbeeley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sheesania @gbeeley