Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

The commits from previous PR have been isolated and additionally, electron and cljs have been slightly bumped #2430

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

The commits from previous PR have been isolated and additionally, electron and cljs have been slightly bumped #2430

wants to merge 14 commits into from

Commits on Apr 3, 2019

  1. Update grunt dependencies and add npm's package-lock.json 

    (cherry picked from commit c2f590c)
    @sbauer322 @prertik
    sbauer322 authored and prertik committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    967ef06 View commit details
    Browse the repository at this point in the history

  2. electron's ipc module has been replaced with ipcMain 

    (cherry picked from commit 3e63cc7)
    @sbauer322 @prertik
    sbauer322 authored and prertik committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    9bb4115 View commit details
    Browse the repository at this point in the history

  3. Electron's ipc module has been replaced with ipcRenderer 

    (cherry picked from commit 5f6a041)
    @sbauer322 @prertik
    sbauer322 authored and prertik committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    1f880b7 View commit details
    Browse the repository at this point in the history

  4. app.getDataPath has been replaced with app.getData 

    (cherry picked from commit b5b1e85)
    @sbauer322 @prertik
    sbauer322 authored and prertik committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    24b22e9 View commit details
    Browse the repository at this point in the history

  5. loadUrl has been replaced with loadURL 

    (cherry picked from commit 0b7607f)
    @sbauer322 @prertik
    sbauer322 authored and prertik committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    a79c26d View commit details
    Browse the repository at this point in the history

  6. min-width and min-height have been replace with minWidth and minHeight 

    (cherry picked from commit 00cd192)
    @sbauer322 @prertik
    sbauer322 authored and prertik committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    7d9f8fa View commit details
    Browse the repository at this point in the history

  7. web-preferences has been replaced with webPreferences 

    (cherry picked from commit 6f717d5)
    @sbauer322 @prertik
    sbauer322 authored and prertik committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    9431270 View commit details
    Browse the repository at this point in the history

  8. browserInjection should use ipcRenderer not ipcMain 

    (cherry picked from commit e80ae29)
    @sbauer322 @prertik
    sbauer322 authored and prertik committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    906fa03 View commit details
    Browse the repository at this point in the history

  9. Replace deprecated electron modules 

    (cherry picked from commit 85bc3fd)
    @sbauer322 @prertik
    sbauer322 authored and prertik committed Apr 3, 2019
    Configuration menu
    Copy the full SHA
    b06fc8d View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. Bump electron and cljs to working versions where code inline eval sti… 

    …ll works

Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
    @prertik
    prertik committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    183a584 View commit details
    Browse the repository at this point in the history

  2. Fix JS errors to address issues raised by Hound 

    Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
    @prertik
    prertik committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    fe8767c View commit details
    Browse the repository at this point in the history

  3. Replace unmaintained optimist with yargs 

    Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
    @prertik
    prertik committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    92cd145 View commit details
    Browse the repository at this point in the history

  4. Each time install npm packages when running script 

    Signed-off-by: Pratik Karki <predatoramigo@gmail.com>
    @prertik
    prertik committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    2047804 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2019

  1. Merge pull request #2432 from LightTable/replace-optimist 

    Replace optimist with yargs
    @prertik
    prertik committed Apr 21, 2019
    Configuration menu
    Copy the full SHA
    37c2d59 View commit details
    Browse the repository at this point in the history