Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more tests of FSDP with HPU #197

Merged
merged 17 commits into from
Jun 25, 2024

Conversation

jyothisambolu
Copy link
Contributor

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

jyothisambolu and others added 5 commits June 21, 2024 18:09
Signed-off-by: jyothi kumar sambolu <jsambolu@habana.ai>
Signed-off-by: jyothi kumar sambolu <jsambolu@habana.ai>
jerome-habana and others added 6 commits June 25, 2024 15:56
Signed-off-by: jyothi kumar sambolu <jsambolu@habana.ai>
Signed-off-by: jyothi kumar sambolu <jsambolu@habana.ai>
Signed-off-by: jyothi kumar sambolu <jsambolu@habana.ai>
Signed-off-by: jyothi kumar sambolu <jsambolu@habana.ai>
@jerome-habana jerome-habana marked this pull request as ready for review June 25, 2024 15:00
@jerome-habana jerome-habana merged commit ecee328 into Lightning-AI:main Jun 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants