Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for lightning 0.10.0 #264

Merged
merged 5 commits into from Oct 12, 2020
Merged

Updates for lightning 0.10.0 #264

merged 5 commits into from Oct 12, 2020

Conversation

nateraw
Copy link
Contributor

@nateraw nateraw commented Oct 7, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@mergify mergify bot requested a review from Borda October 7, 2020 22:34
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #264 into master will decrease coverage by 31.50%.
The diff coverage is 4.87%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #264       +/-   ##
===========================================
- Coverage   85.66%   54.15%   -31.51%     
===========================================
  Files         176      176               
  Lines        9388     9340       -48     
===========================================
- Hits         8042     5058     -2984     
- Misses       1346     4282     +2936     
Flag Coverage 螖
#cpu 24.58% <4.87%> (+0.07%) 猬嗭笍
#pytest 24.58% <4.87%> (+0.07%) 猬嗭笍
#unittests 83.16% <酶> (-2.22%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...ts/models/autoencoders/basic_ae/basic_ae_module.py 25.67% <0.00%> (-62.64%) 猬囷笍
.../models/autoencoders/basic_vae/basic_vae_module.py 22.34% <0.00%> (-69.42%) 猬囷笍
pl_bolts/models/gans/basic/basic_gan_module.py 20.93% <0.00%> (-74.53%) 猬囷笍
...l_bolts/models/self_supervised/byol/byol_module.py 24.73% <0.00%> (-60.54%) 猬囷笍
...lts/models/self_supervised/simclr/simclr_module.py 26.56% <0.00%> (-56.52%) 猬囷笍
pl_bolts/models/self_supervised/ssl_finetuner.py 37.14% <0.00%> (+2.93%) 猬嗭笍
pl_bolts/models/self_supervised/cpc/cpc_module.py 21.09% <7.14%> (-55.07%) 猬囷笍
pl_bolts/models/regression/logistic_regression.py 26.02% <100.00%> (-69.87%) 猬囷笍
pl_bolts/models/rl/common/agents.py 0.00% <0.00%> (-100.00%) 猬囷笍
pl_bolts/models/rl/dueling_dqn_model.py 0.00% <0.00%> (-100.00%) 猬囷笍
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update eac5839...66eb49a. Read the comment docs.

@nateraw nateraw changed the title Use self.log instead of Results Objects Updates for lightning 0.10.0 Oct 7, 2020
@nateraw
Copy link
Contributor Author

nateraw commented Oct 7, 2020

@williamFalcon I think this one is close to being ok, but it seems full testing has been broken since #248 馃槩 .

EDIT - ignore me...failing on unrelated issues

@nateraw nateraw marked this pull request as ready for review October 7, 2020 23:02
@williamFalcon williamFalcon merged commit a8e3fb5 into master Oct 12, 2020
@Borda Borda deleted the update-results branch October 13, 2020 07:55
praecipue added a commit to praecipue/lightning-bolts that referenced this pull request Nov 18, 2021
self.hparams.encoder was renamed to self.hparams.encoder_name in a8e3fb5 Lightning-Universe#264
Rename overlooked occurrence as in 2163626 Lightning-Universe#680
praecipue referenced this pull request in praecipue/lightning-bolts Nov 18, 2021
self.hparams.encoder was renamed to self.hparams.encoder_name in a8e3fb5 PyTorchLightning#264
Rename overlooked occurrence as in 2163626 PyTorchLightning#680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants