Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed CPC module arg name #680

Merged
merged 2 commits into from Jul 4, 2021
Merged

fixed CPC module arg name #680

merged 2 commits into from Jul 4, 2021

Conversation

shatz01
Copy link
Contributor

@shatz01 shatz01 commented Jul 1, 2021

What does this PR do?

Fixes #679

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n] Did you make sure to update the documentation with your changes?
  • [n] Did you write any new necessary tests? [not needed for typos/docs]
  • [n] Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Yes :)
Make sure you had fun coding 馃檭

@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #680 (94e7ce1) into master (270867c) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #680   +/-   ##
=======================================
  Coverage   24.83%   24.83%           
=======================================
  Files         119      119           
  Lines        7321     7321           
=======================================
  Hits         1818     1818           
  Misses       5503     5503           
Flag Coverage 螖
cpu 24.83% <0.00%> (酶)
pytest 24.83% <0.00%> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
pl_bolts/models/self_supervised/cpc/cpc_module.py 20.00% <0.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 270867c...94e7ce1. Read the comment docs.

@shatz01 shatz01 requested a review from Borda July 3, 2021 15:09
@shatz01
Copy link
Contributor Author

shatz01 commented Jul 3, 2021

Oops sorry I didnt mean to request review again from @Borda 馃槵

@Borda Borda changed the title fixed cpc module issue fixed CPC module arg name Jul 4, 2021
@Borda Borda added ready fix fixing issues... labels Jul 4, 2021
@Borda Borda merged commit 2163626 into Lightning-Universe:master Jul 4, 2021
praecipue added a commit to praecipue/lightning-bolts that referenced this pull request Nov 18, 2021
self.hparams.encoder was renamed to self.hparams.encoder_name in a8e3fb5 Lightning-Universe#264
Rename overlooked occurrence as in 2163626 Lightning-Universe#680
praecipue referenced this pull request in praecipue/lightning-bolts Nov 18, 2021
self.hparams.encoder was renamed to self.hparams.encoder_name in a8e3fb5 PyTorchLightning#264
Rename overlooked occurrence as in 2163626 PyTorchLightning#680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fixing issues... model ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when making new CPC_v2 model
3 participants