Fix hparams.encoder forgotten rename in CPCv2 #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip reason is no longer valid. In the meantime another errors were introduced, a workaround is for 2e903c3
praecipue
commented
Nov 18, 2021
praecipue
requested review from
ananyahjha93,
awaelchli,
Borda and
ethanwharris
as code owners
Co-authored-by: praecipue <43908213+praecipue@users.noreply.github.com>
Borda
approved these changes
Nov 26, 2021
|
@praecipue mind check the failing GPU test? just restarted the job to see if it was related to your change... 🐰 |
auto-merge was automatically disabled
November 26, 2021 16:07
Head branch was pushed to by a user without write access
for more information, see https://pre-commit.ci
For some reason spawning DDP process was causing failure. I think it is not related to my change. Is DDP spawn tested anywhere on azure? |
Borda
added a commit
that referenced
this pull request
Nov 29, 2021
* Re-enable testing CPCv2 * Fix hparams forgotten rename in CPCv2 module Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.hparams.encoder was renamed to self.hparams.encoder_name in a8e3fb5 PyTorchLightning#264, but not in forward method. That leads to different errors depending on used encoder module.
CPC module test skip reason is misleading. In the meantime another errors were introduced, a workaround is for 2e903c3
What does this PR do?
Re-enable testing CPCv2
Workaround bug introduced by 2e903c3
The error is misleading, the cause is overlooked hparam rename fixed in the following commit
Fixes problem similar to #680 (#679 issue) and re-enables test
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃