Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ImageNet val loader to use val transform #713

Merged
merged 4 commits into from Aug 29, 2021
Merged

Fix ImageNet val loader to use val transform #713

merged 4 commits into from Aug 29, 2021

Conversation

tridao
Copy link
Contributor

@tridao tridao commented Aug 26, 2021

What does this PR do?

Fix ImageNet val loader to use val transform instead of train transform

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the datamodule Anything related to datamodules label Aug 26, 2021
Copy link
Contributor

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #713 (dc743c7) into master (4046278) will not change coverage.
The diff coverage is n/a.

❗ Current head dc743c7 differs from pull request most recent head a6c763d. Consider uploading reports for the commit a6c763d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #713   +/-   ##
=======================================
  Coverage   72.82%   72.82%           
=======================================
  Files         121      121           
  Lines        7550     7550           
=======================================
  Hits         5498     5498           
  Misses       2052     2052           
Flag Coverage Δ
cpu 72.82% <ø> (ø)
pytest 72.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa7d1df...a6c763d. Read the comment docs.

@SeanNaren SeanNaren merged commit b8a6afa into Lightning-Universe:master Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodule Anything related to datamodules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants