Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics #887

Merged
merged 32 commits into from Sep 23, 2022
Merged

Metrics #887

merged 32 commits into from Sep 23, 2022

Conversation

BaruchG
Copy link
Contributor

@BaruchG BaruchG commented Sep 20, 2022

What does this PR do?

Ensured all tests are there for object detection metrics and it's not duplicated. Part of the Lightning Bolts cleanup effort.

Part of #839

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

BaruchG and others added 30 commits August 8, 2022 17:05
@BaruchG BaruchG marked this pull request as ready for review September 22, 2022 18:41
@otaj
Copy link
Contributor

otaj commented Sep 23, 2022

It seems torchvision has these metrics for quite some time already

@BaruchG
Copy link
Contributor Author

BaruchG commented Sep 23, 2022

Thanks for catching that @otaj, I'll swap them out.

@mergify mergify bot added the ready label Sep 23, 2022
@Borda Borda enabled auto-merge (squash) September 23, 2022 22:14
@Borda Borda merged commit 6f58d71 into Lightning-Universe:master Sep 23, 2022
@BaruchG BaruchG mentioned this pull request Sep 30, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants