Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics #892

Merged
merged 54 commits into from Nov 4, 2022
Merged

Metrics #892

merged 54 commits into from Nov 4, 2022

Conversation

BaruchG
Copy link
Contributor

@BaruchG BaruchG commented Sep 30, 2022

What does this PR do?

Continuation of #887 and replaces our iou and giou with torchvision versions.

Fixes part of #839

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

BaruchG and others added 30 commits August 8, 2022 17:05
@BaruchG BaruchG marked this pull request as ready for review October 31, 2022 19:24
@mergify mergify bot added ready and removed has conflicts labels Nov 2, 2022
@mergify mergify bot added the has conflicts label Nov 3, 2022
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about removing these functions instead of having the exact same things with different names? Or are we keeping these for backwards-compatibility?

@otaj
Copy link
Contributor

otaj commented Nov 4, 2022

Yeah, @akihironitta, this is for backwards compatibility.

@mergify mergify bot removed the has conflicts label Nov 4, 2022
@akihironitta akihironitta merged commit 894456f into Lightning-Universe:master Nov 4, 2022
@BaruchG BaruchG deleted the metrics branch November 22, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants