Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected keyword arg 'inplace' for torch.nn.SiLU #455

Closed
Tracked by #266
athitten opened this issue May 24, 2024 · 2 comments · Fixed by #570
Closed
Tracked by #266

Unexpected keyword arg 'inplace' for torch.nn.SiLU #455

athitten opened this issue May 24, 2024 · 2 comments · Fixed by #570
Assignees
Labels
bug Something isn't working nemo Issues needed to support NVIDIA NeMo models.

Comments

@athitten
Copy link

athitten commented May 24, 2024

🐛 Bug

NeMo's StableDiffusion uses SiLU activation in its UNet model. When UNet stage is run with thunder.jit, thunder gives an error:
silu() got an unexpected keyword argument 'inplace'.
Specifically the error is is raised in this line of torch/nn/modules/activation.py although inplace is a valid argument of the op.

CC: @tfogal

cc @tfogal

@athitten athitten added the bug Something isn't working label May 24, 2024
@tfogal
Copy link
Collaborator

tfogal commented May 24, 2024

I had a chat with @athitten on this one. The SiLu in question is purely internal to the model--we could just functionalize this as a solution.

@tfogal tfogal added the nemo Issues needed to support NVIDIA NeMo models. label May 24, 2024
@riccardofelluga riccardofelluga self-assigned this Jun 10, 2024
@mruberry
Copy link
Collaborator

triage review —

  • we can add the inplace argument to the signature and throw a NotImplementedError if it's True for now, that will also provide a more informative error message to tell us if this is actually being used inplace
  • we should revisit general inplace operator support with Q3 planning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working nemo Issues needed to support NVIDIA NeMo models.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants