Add inplace kwarg to torch.nn.functional.silu
#570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardofelluga
requested review from
mruberry,
lantiga,
robieta and
t-vi
as code owners
for more information, see https://pre-commit.ci
t-vi
reviewed
Jun 11, 2024
thunder/torch/__init__.py
Outdated
| @@ -1486,7 +1486,8 @@ def selu(a: TensorProxy, /, inplace: bool = False) -> TensorLike: | |||
|
|
|||
|
|
|||
| @torchsymbol(torch.nn.functional.silu) | |||
| def silu(a, /): | |||
| def silu(a: TensorLike, inplace: bool = False): | |||
| utils.check(not inplace, lambda: "silu only supports inplace=False", exception_type=NotImplementedError) | |||
There was a problem hiding this comment.
I might be nice to include "Thunder" somewhere in the error message so people know it's us not them...
t-vi
approved these changes
Jun 11, 2024
|
why is ref: lightning-thunder/thunder/torch/__init__.py Line 1459 in 8309fc0 |
|
Probably because it's terrible to pass this without keyword, but you're right, we should ideally match the PyTorch signature. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Temporarily fixes #455 till we implement inplace operators by adding the keyword arg to the operator implementation.
I changed from testing the clang to testing the ltorch symbol as it is a superset of clang in this case so we test both.