Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing numberproxy trace mode check #450

Merged
merged 4 commits into from
May 25, 2024

Conversation

jjsjann123
Copy link
Collaborator

@jjsjann123 jjsjann123 commented May 24, 2024

trace & language context should both be present in order to trace operations on NumberProxy.

thunder/core/baseutils.py Outdated Show resolved Hide resolved
@jjsjann123 jjsjann123 marked this pull request as ready for review May 24, 2024 17:23
@lantiga lantiga merged commit 4c9a765 into Lightning-AI:main May 25, 2024
38 of 40 checks passed
@jjsjann123 jjsjann123 deleted the trace_mode_detection branch May 25, 2024 18:29
crcrpar pushed a commit that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants