Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python executor should be able to handle NumberProxy #484

Merged
merged 2 commits into from
May 29, 2024
Merged

python executor should be able to handle NumberProxy #484

merged 2 commits into from
May 29, 2024

Conversation

jjsjann123
Copy link
Collaborator

extend the support from binary op to unary/cast

cherry-picked small fixes from #250

@jjsjann123 jjsjann123 requested a review from kiya00 May 29, 2024 18:54
@jjsjann123
Copy link
Collaborator Author

jjsjann123 commented May 29, 2024 •
edited
Loading

@kiya00 is running issue with this in resnet. I'm pulling in the fix to unblock her.

@kiya00 run into issue with pythonex rejecting unary op on NumberProxy, this PR is to resolve the issue and unblock her.

lantiga
lantiga approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, stamped!

@lantiga lantiga merged commit bc3925b into Lightning-AI:main May 29, 2024
37 checks passed
@jjsjann123 jjsjann123 deleted the patch_pythonex_numberproxy_check branch May 29, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga lantiga approved these changes

@kiya00 kiya00 Awaiting requested review from kiya00

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@robieta robieta Awaiting requested review from robieta

@t-vi t-vi Awaiting requested review from t-vi t-vi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjsjann123 @lantiga