Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the if condition to warn only for relevant input params #736

Merged

Conversation

wprazuch
Copy link
Contributor

@wprazuch wprazuch commented Jul 9, 2024

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

As a follow-up for the reported issue, this PR adds a more constrained condition for warning about activation checkpointing. It makes sure the warning is shown only for relevant input configuration.

The reason for this change is that if we use activation checkpointing for eager or inductor, we get in the logs:

Activations checkpointing is configured, but Thunder does not support checkpointing. Checkpointing will be ignored.

which confused us as we thought we had a bug and run Thunder instead of the above mentioned compiler backends.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@mruberry
Copy link
Collaborator

mruberry commented Jul 9, 2024

fyi @IvanYashchuk -- seems totally reasonable, but maybe in the future we should do something more structured than a string match with the name?

Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry mruberry enabled auto-merge (squash) July 9, 2024 19:34
@mruberry
Copy link
Collaborator

mruberry commented Jul 9, 2024

@t-vi The failure is a flaky test:

FAILED thunder/tests/test_grad.py::test_vjp_correctness_fmod_torch_cuda_thunder.dtypes.float64 - AssertionError: Scalars are not close!

Expected 2.1955857910908714 but got 497.02388012862195.
Absolute difference: 494.8282943375311 (up to 1e-07 allowed)
Relative difference: 225.3741558837821 (up to 1e-07 allowed)

So this will probably require manual merging.

@IvanYashchuk do we have issue for flaky fmod?

@mruberry mruberry merged commit 7d62ae1 into Lightning-AI:main Jul 9, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants