Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the if condition to warn only for relevant input params #736

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Adjust the if condition to warn only for relevant input params #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion thunder/benchmarks/benchmark_litgpt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ def __init__(
self.global_batch_size % self.micro_batch_size * world_size == 0
), f"Global Batch Size {self.global_batch_size} should be a multiple Micro Batch Size {self.micro_batch_size} * World Size {world_size}."

if self.checkpoint_activations:
if self.checkpoint_activations and "thunder" in self.compile:
warnings.warn(
"Activations checkpointing is configured, but Thunder does not support checkpointing. Checkpointing will be ignored."
)
Expand Down
Loading