Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LitData: set iterate_over_all to False for CombinedStreamingDataset #1404

Merged
merged 2 commits into from
May 10, 2024
Merged

LitData: set iterate_over_all to False for CombinedStreamingDataset #1404

merged 2 commits into from
May 10, 2024

Conversation

Andrei-Aksionov
Copy link
Collaborator

Hi there 👋

This PR basically does what Adrian wrote:

LitData made the decision to enforce iterate_over_all by default as a breaking change. LitGPT will have to set iterate_over_all=False explicitly now and require litdata>=0.2.6. The error message needs to be fixed though.

Originally posted by @awaelchli in #1399 (comment)

The change is done in CombinedStreamingDataset which is used in one place only: TinyLlaMA DataModule.

Fixes #1399

awaelchli
awaelchli approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@Andrei-Aksionov Andrei-Aksionov marked this pull request as ready for review May 9, 2024 16:36
@carmocca carmocca merged commit 20383ed into Lightning-AI:main May 10, 2024
9 checks passed
@Andrei-Aksionov Andrei-Aksionov deleted the litdata_iterate_over_all_default_to_false branch May 10, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca Awaiting requested review from carmocca

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_tinyllama issue with LitData and iterate_over_all
3 participants
@Andrei-Aksionov @awaelchli @carmocca