Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fid: error on too few samples #1655

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Fid: error on too few samples #1655

merged 4 commits into from
Mar 28, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes #1652

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Mar 26, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 26, 2023
@SkafteNicki SkafteNicki requested a review from Borda as a code owner March 26, 2023 14:35
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #1655 (578a021) into master (685391d) will decrease coverage by 48%.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1655     +/-   ##
========================================
- Coverage      89%     40%    -48%     
========================================
  Files         228     228             
  Lines       12363   12365      +2     
========================================
- Hits        10945    5004   -5941     
- Misses       1418    7361   +5943     

@Borda Borda enabled auto-merge (squash) March 26, 2023 15:32
@mergify mergify bot added the ready label Mar 26, 2023
@mergify mergify bot requested a review from a team March 26, 2023 15:32
@Borda Borda disabled auto-merge March 28, 2023 10:16
@mergify mergify bot removed the has conflicts label Mar 28, 2023
@Borda Borda merged commit bf4574e into master Mar 28, 2023
@Borda Borda deleted the bugfix/fid_too_few_samples branch March 28, 2023 10:16
@mergify mergify bot removed the ready label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working topic: Image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FID.compute() throws imprecise error with batch size of 1
3 participants