Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing on macOS is always skipped in CI #14564

Closed
akihironitta opened this issue Sep 6, 2022 · 1 comment · Fixed by #14565
Closed

Testing on macOS is always skipped in CI #14564

akihironitta opened this issue Sep 6, 2022 · 1 comment · Fixed by #14565
Assignees
Labels
ci Continuous Integration priority: 0 High priority task
Milestone

Comments

@akihironitta
Copy link
Contributor

akihironitta commented Sep 6, 2022

🐛 Bug

When any change is added to PL codebase, tests should run in all operating systems such as ubuntu, windows and macos. However, tests on macos always get skipped.

To Reproduce

See an example in #14563 https://github.com/Lightning-AI/lightning/actions/runs/3002282279

Expected behavior

Don't skip.

Environment

macos in CI

Additional context

The skipping logic was originally added in #13661.

cc @tchaton @rohitgr7 @carmocca @akihironitta @Borda

@akihironitta
Copy link
Contributor Author

It turns out that the issue is due to the lack of memory in macOS runners:

> changed-files
  Resolving repository path: /Users/runner/work/lightning/lightning/.
  Retrieving changes between 273a9ed8c14650c59b60c546fe53d93a4183d439 (master) → c4a680f471c3f03a20b4d59735904926189387c4 (ci/trigger-macos)
  Getting diff...
  grep: out of memory
  grep: out of memory
  grep: out of memory
  grep: out of memory
  grep: out of memory
  grep: out of memory
  grep: out of memory
  grep: out of memory
  grep: out of memory
  grep: out of memory
  grep: out of memory

https://github.com/Lightning-AI/lightning/runs/8213161059?check_suite_focus=true#step:3:134


There is a beta feature enabling the GitHub-hosted runners to have more resources (https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners), but I don't think it's worth adapting it just for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration priority: 0 High priority task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant