Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Combine conda and full testing into a single workflow #14387

Merged
merged 60 commits into from
Sep 30, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Aug 25, 2022

What does this PR do?

Addresses #14059.
Includes and closes #14565.

TODO

  • Agree on the version matrix for testing
  • Update docs
  • Update checkgroup

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@akihironitta akihironitta added ci Continuous Integration priority: 2 Low priority task labels Aug 25, 2022
@akihironitta akihironitta removed the priority: 2 Low priority task label Sep 6, 2022
@akihironitta akihironitta added this to the pl:1.7.x milestone Sep 8, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Sep 20, 2022
Borda
Borda previously requested changes Sep 20, 2022
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is intentional that all Azure configs are deleted?

@akihironitta
Copy link
Contributor Author

It is intentional that all Azure configs are deleted?

Will revert the change! (I just didn't want to occupy the resources with the unrelated change in this PR)

@mergify mergify bot removed the has conflicts label Sep 29, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Sep 29, 2022
@akihironitta
Copy link
Contributor Author

akihironitta commented Sep 29, 2022

As requested in #14059 (reply in thread), 114a4c0 added Python/PyTorch versions that were used in conda jobs. If there's no issue with all combinations here, this PR is ready.

@carmocca @awaelchli You've already left an approval, but please have another look if necessary.


Conda installation testing will be added via #14374 independently of this PR.

@akihironitta akihironitta changed the title [wip] CI: Combine conda and full testing into a single workflow CI: Combine conda and full testing into a single workflow Sep 29, 2022
.github/workflows/ci-pytorch-dockers.yml Outdated Show resolved Hide resolved
.github/workflows/ci-pytorch-test-full.yml Show resolved Hide resolved
.github/checkgroup.yml Show resolved Hide resolved
@akihironitta akihironitta added the admin Requires admin privileges to merge label Sep 29, 2022
@carmocca carmocca dismissed Borda’s stale review September 30, 2022 00:58

The azure configs have been added back

@mergify mergify bot added the ready PRs ready to be merged label Sep 30, 2022
@lexierule lexierule merged commit e47d5a2 into master Sep 30, 2022
@lexierule lexierule deleted the ci/combine-conda-full branch September 30, 2022 02:39
@akihironitta akihironitta mentioned this pull request Sep 30, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Requires admin privileges to merge ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants