-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove skipping logic in PL CI #14565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but this will increase the burden of app development until #14294 is finished. Hopefully within this week. This is because these jobs are marked as required so they cannot be skipped with a path filter.
56a4474
to
2f6fab2
Compare
Should we maybe merge #14294 and this one together on the same day when both are ready? |
What does this PR do?
[hotfix] Fixes #14564.
Partially redo #14170 but for a different reason stated in the above issue.
The impact coverage is only PL, so I'm adding this PR to 1.7.x milestone.
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 馃檭
cc @tchaton @rohitgr7 @carmocca @akihironitta @Borda