Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop torch 1.6 testing #10390

Merged
merged 22 commits into from Nov 13, 2021
Merged

Drop torch 1.6 testing #10390

merged 22 commits into from Nov 13, 2021

Conversation

carmocca
Copy link
Member

@carmocca carmocca commented Nov 6, 2021 •
edited

What does this PR do?

Follow-up to #10367

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the ci Continuous Integration label Nov 6, 2021
@carmocca carmocca added this to the v1.6 milestone Nov 6, 2021
@carmocca carmocca self-assigned this Nov 6, 2021
@carmocca carmocca marked this pull request as draft November 6, 2021 19:02
@carmocca carmocca mentioned this pull request Nov 7, 2021
Merged
11 tasks
@justusschock justusschock mentioned this pull request Nov 8, 2021
Closed
12 tasks
Base automatically changed from ci/drop-1.6 to master November 8, 2021 11:29
carmocca
carmocca commented Nov 8, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@carmocca carmocca marked this pull request as ready for review November 8, 2021 16:18
tchaton
tchaton approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/distributed/dist.py Show resolved Hide resolved
pytorch_lightning/trainer/connectors/accelerator_connector.py Show resolved Hide resolved
pytorch_lightning/utilities/auto_restart.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 9, 2021
@justusschock justusschock enabled auto-merge (squash) November 9, 2021 08:26
@mergify mergify bot added the has conflicts label Nov 9, 2021
@mergify mergify bot removed the has conflicts label Nov 10, 2021
akihironitta
akihironitta approved these changes Nov 11, 2021
View reviewed changes
pytorch_lightning/plugins/training_type/ddp.py Outdated Show resolved Hide resolved
pytorch_lightning/plugins/training_type/ddp_spawn.py Outdated Show resolved Hide resolved
carmocca and others added 2 commits November 11, 2021 15:30
@carmocca @akihironitta
Apply suggestions from code review
126aedb 
Co-authored-by: Aki Nitta <nitta@akihironitta.com>
@carmocca
Fix message
99cece8
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #10390 (99cece8) into master (d2aaf6b) will increase coverage by 0%.
The diff coverage is 75%.

@@           Coverage Diff           @@
##           master   #10390   +/-   ##
=======================================
  Coverage      92%      93%           
=======================================
  Files         179      178    -1     
  Lines       16292    16220   -72     
=======================================
- Hits        15063    15013   -50     
+ Misses       1229     1207   -22

@justusschock justusschock merged commit 7a9a08c into master Nov 13, 2021
@justusschock justusschock deleted the tests/drop-1.6 branch November 13, 2021 20:35
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@carmocca @akihironitta @Raalsky
Drop torch 1.6 testing (Lightning-AI#10390)
3bce41a 
* Drop torch 1.6 support

* Drop 1.6 support

* Update CHANGELOG

* Fixes

* Split change

* Undo change

* 1.7 -> 1.7.1

pytorch/pytorch#47354

* Force trigger nightly

* Update .github/workflows/events-nightly.yml

Co-authored-by: Aki Nitta <nitta@akihironitta.com>

* Revert 1.7.1 change - try wildcard

* Update adjust versions and test it

* Undo test changes

* Revert "Undo test changes"

This reverts commit 3a6acad.

* Update CHANGELOG.md

Co-authored-by: Aki Nitta <nitta@akihironitta.com>
@awaelchli awaelchli mentioned this pull request Nov 24, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanwharris ethanwharris ethanwharris approved these changes

@tchaton tchaton tchaton approved these changes

@justusschock justusschock justusschock approved these changes

@akihironitta akihironitta akihironitta approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@carmocca @ethanwharris @tchaton @justusschock @akihironitta @kaushikb11