Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync CI configuration into 1.5.x branch #10738

Merged
merged 2 commits into from Nov 25, 2021
Merged

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Nov 24, 2021

What does this PR do?

Syncs the CI configuration from master, dropping the support for torch 1.6 and fixing our CI jobs here.
All changes in these files are now identical to the ones on master, no other changes were done here.

Done via git checkout master .github/workflows requirements/ ... etc.

These are the PRs that updated the configuration on master:
#10367
#10075
#10088
#10390

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 馃檭

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @carmocca @akihironitta @Borda

@awaelchli awaelchli added ci Continuous Integration release labels Nov 24, 2021
@awaelchli awaelchli added this to the 1.5.x milestone Nov 24, 2021
@awaelchli awaelchli marked this pull request as ready for review November 24, 2021 22:02
Copy link
Member

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests are green.

Remember to update the CHANGELOG: https://github.com/PyTorchLightning/pytorch-lightning/blame/master/CHANGELOG.md#L130

@awaelchli awaelchli mentioned this pull request Nov 24, 2021
11 tasks
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :]

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Nov 25, 2021
@justusschock justusschock enabled auto-merge (squash) November 25, 2021 10:24
@lexierule lexierule merged commit 90d362a into release/1.5.x Nov 25, 2021
@lexierule lexierule deleted the 1.5.x-drop-torch-1.6 branch November 25, 2021 14:24
kaushikb11 pushed a commit that referenced this pull request Nov 30, 2021
lexierule pushed a commit that referenced this pull request Nov 30, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants