Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log_text, and log_image from LightningLoggerBase API #11857

Merged
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,10 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Removed `FitLoop.current_epoch` getter and setter ([#11562](https://github.com/PyTorchLightning/pytorch-lightning/pull/11562))


- Removed access to `_short_id` in `NeptuneLogger` ([#11517](https://github.com/PyTorchLightning/pytorch-lightning/pull/11517))
- Removed access to `_short_id` in `NeptuneLogger` ([#11517](https://github.com/PyTorchLightning/pytorch-lightning/pull/11517))
akashkw marked this conversation as resolved.
Show resolved Hide resolved


- Removed `log_text` and `log_image` from the `LightningLoggerBase` API ([#11857](https://github.com/PyTorchLightning/pytorch-lightning/pull/11857))


### Fixed
Expand Down
14 changes: 0 additions & 14 deletions pytorch_lightning/loggers/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,20 +190,6 @@ def log_graph(self, model: "pl.LightningModule", input_array=None) -> None:
"""
pass

def log_text(self, *args, **kwargs) -> None:
"""Log text.

Arguments are directly passed to the logger.
"""
raise NotImplementedError

def log_image(self, *args, **kwargs) -> None:
"""Log image.

Arguments are directly passed to the logger.
"""
raise NotImplementedError

def save(self) -> None:
"""Save log data."""
self._finalize_agg_metrics()
Expand Down