Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove log_text, and log_image from LightningLoggerBase API #11857

Merged
merged 7 commits into from Feb 18, 2022
Merged

Remove log_text, and log_image from LightningLoggerBase API #11857

merged 7 commits into from Feb 18, 2022

Conversation

akashkw
Copy link
Contributor

@akashkw akashkw commented Feb 10, 2022 •
edited

What does this PR do?

log_text, and log_image, are not overridden in many logger implementations. They have now been removed.

Fixes #11837

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@akashkw akashkw marked this pull request as draft February 10, 2022 20:38
@akashkw akashkw marked this pull request as ready for review February 10, 2022 21:12
daniellepintz
daniellepintz reviewed Feb 10, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@akashkw akashkw changed the title Remove log_graph, log_text, and log_image from LightningLoggerBase API Remove log_text, and log_image from LightningLoggerBase API Feb 10, 2022
akashkw
akashkw commented Feb 10, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
edward-io
edward-io approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@edward-io edward-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

daniellepintz
daniellepintz approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@daniellepintz daniellepintz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@akashkw akashkw added deprecation Includes a deprecation logger Related to the Loggers labels Feb 11, 2022
@mergify mergify bot added the ready PRs ready to be merged label Feb 17, 2022
@daniellepintz daniellepintz added this to the 1.6 milestone Feb 18, 2022
@daniellepintz
Copy link
Contributor

Looks ready to be merged!

@ananthsub ananthsub merged commit 73e9ca3 into Lightning-AI:master Feb 18, 2022
@ananthsub ananthsub added breaking change Includes a breaking change deprecation Includes a deprecation and removed deprecation Includes a deprecation breaking change Includes a breaking change labels Feb 18, 2022
carmocca pushed a commit that referenced this pull request Feb 18, 2022
@akashkw @carmocca
Remove log_text, and log_image from LightningLoggerBase API (#1…
c6aae7a 
…1857)
@akashkw akashkw deleted the refactor/remove-graph-text-image-from-logger-base branch February 18, 2022 19:32
@entn-at entn-at mentioned this pull request Jan 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananthsub ananthsub ananthsub approved these changes

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

@daniellepintz daniellepintz daniellepintz approved these changes

@edward-io edward-io edward-io approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees
No one assigned
Labels
deprecation Includes a deprecation logger Related to the Loggers ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

[RFC] Remove log_text and log_image from LightningLoggerBase API
6 participants
@akashkw @daniellepintz @ananthsub @awaelchli @carmocca @edward-io