-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated logger.close
#13149
Merged
akihironitta
merged 8 commits into
Lightning-AI:master
from
ishtos:refactor/12521_remove_close_method_of_LoggerCollection
Jun 1, 2022
Merged
Remove the deprecated logger.close
#13149
akihironitta
merged 8 commits into
Lightning-AI:master
from
ishtos:refactor/12521_remove_close_method_of_LoggerCollection
Jun 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishtos
requested review from
tchaton,
awaelchli,
Borda,
williamFalcon,
SeanNaren,
carmocca,
justusschock,
kaushikb11 and
rohitgr7
as code owners
May 25, 2022 12:09
carmocca
added
logger
Related to the Loggers
breaking change
Includes a breaking change
community
This PR is from the community
labels
May 25, 2022
carmocca
changed the title
refactor:removed the close instance from the LoggerCollection class
Remove the deprecated May 25, 2022
logger.close
carmocca
approved these changes
May 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I also removed Logger.close()
Thank you! |
Borda
approved these changes
May 25, 2022
akihironitta
approved these changes
May 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
44 tasks
ananthsub
approved these changes
May 25, 2022
justusschock
approved these changes
May 25, 2022
carmocca
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
community
This PR is from the community
logger
Related to the Loggers
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #12521
resolves #9422
Does your PR introduce any breaking changes? If yes, please list them.
Removes the deprecated
close
method from Loggers in favour offinalize
.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃