Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lite's collectives feature #14996

Closed
wants to merge 48 commits into from
Closed

Lite's collectives feature #14996

wants to merge 48 commits into from

Conversation

carmocca
Copy link
Member

@carmocca carmocca commented Oct 4, 2022

What does this PR do?

Fixes (keep open) #7534 for Lite
Fixes #13821.

TODO:

  • Integrate into the strategies
  • Clean up random distributed files (marked with FIXME).
  • Docstrings
  • Tests

Open questions:

Constraints:

  • Async operations are not supported. They can only be implemented for PyTorch but they break the LSP with the Collective as they would require a generalized return in the base class.

Does your PR introduce any breaking changes? If yes, please list them.

None, as the new Lite is unreleased.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added feature Is an improvement or enhancement distributed Generic distributed-related topic fabric lightning.fabric.Fabric labels Oct 4, 2022
@carmocca carmocca self-assigned this Oct 4, 2022
@otaj otaj self-assigned this Oct 5, 2022
src/lightning_lite/plugins/collectives/collective.py Outdated Show resolved Hide resolved
src/lightning_lite/plugins/collectives/collective.py Outdated Show resolved Hide resolved
src/lightning_lite/plugins/collectives/collective.py Outdated Show resolved Hide resolved
src/lightning_lite/plugins/collectives/collective.py Outdated Show resolved Hide resolved
src/lightning_lite/plugins/collectives/collective.py Outdated Show resolved Hide resolved
src/lightning_lite/plugins/collectives/collective.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 5, 2022
from lightning_lite.strategies.deepspeed import _DEEPSPEED_AVAILABLE
from lightning_lite.utilities.types import CollectibleGroup

if _DEEPSPEED_AVAILABLE:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the spirit of #12786, we should make these local imports

Copy link

gitguardian bot commented Jan 16, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 78fa3af tests/tests_app/utilities/test_login.py View secret
- Base64 Basic Authentication 78fa3af tests/tests_app/utilities/test_login.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@carmocca carmocca closed this Apr 22, 2024
@carmocca carmocca deleted the feat/collectives branch April 22, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Generic distributed-related topic fabric lightning.fabric.Fabric feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use DeepSpeed Communication
2 participants