Introduce base collective and main subclasses #15016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
added
feature
carmocca
requested review from
justusschock,
Borda and
kaushikb11
as code owners
carmocca
commented
Oct 6, 2022
justusschock
reviewed
Oct 6, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #15016 +/- ##
=========================================
+ Coverage 83% 85% +2%
=========================================
Files 396 280 -116
Lines 29103 21519 -7584
=========================================
- Hits 24089 18220 -5869
+ Misses 5014 3299 -1715 |
added 2 commits
October 6, 2022 15:27
awaelchli
approved these changes
Oct 7, 2022
tests/tests_lite/plugins/collectives/test_single_device_collective.py
Outdated
Show resolved
Hide resolved
otaj
approved these changes
Oct 7, 2022
justusschock
approved these changes
Oct 7, 2022
src/lightning_lite/plugins/collectives/single_device_collective.py
Outdated
Show resolved
Hide resolved
nicolai86
pushed a commit
that referenced
this pull request
Oct 13, 2022
Co-authored-by: otaj <ota@lightning.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part 1 of #14996
For now, the classes have not been integrated. Also not exposed from the
lite.pluginsDoes your PR introduce any breaking changes? If yes, please list them.
None
cc @Borda @awaelchli @rohitgr7 @akihironitta @carmocca @justusschock