Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for command descriptions #15193

Merged
merged 5 commits into from
Oct 19, 2022
Merged

Add support for command descriptions #15193

merged 5 commits into from
Oct 19, 2022

Conversation

ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Oct 19, 2022 •
edited by github-actions bot

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

cc @Borda

@ethanwharris ethanwharris added app Generic label for Lightning App package app:cli labels Oct 19, 2022
@ethanwharris ethanwharris marked this pull request as ready for review October 19, 2022 15:00
tchaton
tchaton approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

@mergify mergify bot added the ready PRs ready to be merged label Oct 19, 2022
@ethanwharris ethanwharris added this to the future milestone Oct 19, 2022
@ethanwharris ethanwharris merged commit 4acb10f into master Oct 19, 2022
@ethanwharris ethanwharris deleted the feature/command_descriptions branch October 19, 2022 16:34
Borda pushed a commit that referenced this pull request Oct 19, 2022
@ethanwharris @Borda
Add support for command descriptions (#15193)
aad024d 
(cherry picked from commit 4acb10f)
Borda pushed a commit that referenced this pull request Oct 19, 2022
@ethanwharris @Borda
Add support for command descriptions (#15193)
b594a89 
(cherry picked from commit 4acb10f)
Borda pushed a commit that referenced this pull request Oct 19, 2022
@ethanwharris @Borda
Add support for command descriptions (#15193)
04b748e 
(cherry picked from commit 4acb10f)
Borda pushed a commit that referenced this pull request Oct 19, 2022
@ethanwharris @Borda
Add support for command descriptions (#15193)
4e00ba7 
(cherry picked from commit 4acb10f)
@carmocca carmocca modified the milestones: future, v1.8 Oct 19, 2022
lantiga pushed a commit that referenced this pull request Oct 20, 2022
@Borda @alecmerdler
@edenlightning @ethanwharris
Releasing app 0.7 (#15197)
b73087c 
* Support Injecting Secrets into Apps Running in the Cloud (#14612)

Adds a new '--secret' flag to 'lightning run app':

lightning run app --cloud --secret MY_SECRET=my-secret-name app.py

When the Lightning App runs in the cloud, the 'MY_SECRET'
environment variable will be populated with the value of the
referenced Secret. The value of the Secret is encrypted in the
database, and will only be decrypted and accessible to the
Flow/Work processes in the cloud.

Co-authored-by: Sherin Thomas <sherin@grid.ai>
Co-authored-by: Noha Alon <nohalon@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>

(cherry picked from commit 71719b9)

* secrets docs (#14951)

* secrets docs

* Update docs/source-app/glossary/secrets.rst

Co-authored-by: Yurij Mikhalevich <yurij@grid.ai>

* Apply suggestions from code review

Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>

* Update secrets.rst

* links

Co-authored-by: Yurij Mikhalevich <yurij@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
(cherry picked from commit 8715cd0)

# Conflicts:
#	docs/source-app/glossary/secrets.rst

* Add support for command descriptions (#15193)

(cherry picked from commit 4acb10f)

* docs: temp drop S3 from index (#15099)

Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
(cherry picked from commit 05d91c8)

* version 0.7.0

* chlog join 0.6.3 & 0.7

Co-authored-by: Alec Merdler <alecmerdler@gmail.com>
Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
Co-authored-by: Ethan Harris <ethanwharris@gmail.com>
tchaton pushed a commit that referenced this pull request Oct 24, 2022
@ethanwharris @tchaton
Add support for command descriptions (#15193)
63a03c4
@tchaton tchaton added the bug Something isn't working label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manskx manskx manskx approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@hhsecond hhsecond Awaiting requested review from hhsecond

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

Assignees
No one assigned
Labels
app:cli app Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ethanwharris @manskx @tchaton @carmocca