Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releasing app 0.7 #15197

Merged
merged 6 commits into from
Oct 20, 2022
Merged

Releasing app 0.7 #15197

merged 6 commits into from
Oct 20, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 19, 2022 •
edited by github-actions bot

What does this PR do?

releasing App 0.7

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

cc @Borda

@Borda Borda added the release label Oct 19, 2022
@Borda Borda added this to the future milestone Oct 19, 2022
@Borda Borda changed the title Releasing app Releasing app 0.7 Oct 19, 2022
@github-actions github-actions bot added the app Generic label for Lightning App package label Oct 19, 2022
@alecmerdler @Borda
Support Injecting Secrets into Apps Running in the Cloud (#14612)
70b84f5 
Adds a new '--secret' flag to 'lightning run app':

lightning run app --cloud --secret MY_SECRET=my-secret-name app.py

When the Lightning App runs in the cloud, the 'MY_SECRET'
environment variable will be populated with the value of the
referenced Secret. The value of the Secret is encrypted in the
database, and will only be decrypted and accessible to the
Flow/Work processes in the cloud.

Co-authored-by: Sherin Thomas <sherin@grid.ai>
Co-authored-by: Noha Alon <nohalon@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>

(cherry picked from commit 71719b9)
@mergify mergify bot removed the has conflicts label Oct 19, 2022
@edenlightning @Borda
secrets docs (#14951)
3e9459f 
* secrets docs

* Update docs/source-app/glossary/secrets.rst

Co-authored-by: Yurij Mikhalevich <yurij@grid.ai>

* Apply suggestions from code review

Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>

* Update secrets.rst

* links

Co-authored-by: Yurij Mikhalevich <yurij@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
(cherry picked from commit 8715cd0)

# Conflicts:
#	docs/source-app/glossary/secrets.rst
@Borda Borda force-pushed the releasing-app branch 2 times, most recently from 4641f3d to c5fb04e Compare October 19, 2022 17:53
@Borda
Copy link
Member Author

Borda commented Oct 19, 2022

@nohalon @edenlightning mind checking again 馃Ζ

ethanwharris and others added 3 commits October 19, 2022 20:15
@ethanwharris @Borda
Add support for command descriptions (#15193)
4e00ba7 
(cherry picked from commit 4acb10f)
@Borda
docs: temp drop S3 from index (#15099)
4838426 
Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
(cherry picked from commit 05d91c8)
@Borda
version 0.7.0
1d13a10
nohalon
nohalon approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@nohalon nohalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks jirka!!

@mergify mergify bot added the ready PRs ready to be merged label Oct 20, 2022
@tchaton
Copy link
Contributor

tchaton commented Oct 20, 2022 •
edited

@Borda Could you include all the commits from the master? I don't see those commits: #14995 and #15187

And could we release an RC instead to validate everything works as expected before to do a major release ?

@Borda
Copy link
Member Author

Borda commented Oct 20, 2022

Could you include all the commits from the master? I don't see those commits: #14995 and #15187

not really; this is specifically requested for secrets, so your components will follow in a few days, or we can make RC from master

hhsecond
hhsecond approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@hhsecond hhsecond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lantiga
lantiga approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lantiga lantiga merged commit b73087c into release/app Oct 20, 2022
@lantiga lantiga deleted the releasing-app branch October 20, 2022 12:42
@Borda Borda modified the milestones: future, app:0.7 Oct 20, 2022
@Borda
Copy link
Member Author

Borda commented Oct 20, 2022

ok, this shall be rebase & merge but never mind 馃Ζ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lantiga lantiga lantiga approved these changes

@nohalon nohalon nohalon approved these changes

@hhsecond hhsecond hhsecond approved these changes

@edenlightning edenlightning edenlightning approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@manskx manskx Awaiting requested review from manskx

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees
No one assigned
Labels
app Generic label for Lightning App package ready PRs ready to be merged release
Projects
None yet
Milestone
app:0.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Borda @tchaton @lantiga @nohalon @hhsecond @edenlightning @alecmerdler @ethanwharris