Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Pillow 8.3.0 due to errors with numpy #8234

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jul 1, 2021

What does this PR do?

        img = torch.from_numpy(
>           np.array(pic, mode_to_nptype.get(pic.mode, np.uint8), copy=True)
        )
E       TypeError: __array__() takes 1 positional argument but 2 were given

/opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages/torchvision/transforms/functional.py:129: TypeError

python-pillow/Pillow#5571

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added the ci Continuous Integration label Jul 1, 2021
@carmocca carmocca added this to the v1.3.x milestone Jul 1, 2021
@carmocca carmocca self-assigned this Jul 1, 2021
@codecov
Copy link

codecov bot commented Jul 1, 2021

Codecov Report

Merging #8234 (86f9328) into master (36b893c) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #8234   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files         212     212           
  Lines       13679   13679           
======================================
- Hits        12104   12037   -67     
- Misses       1575    1642   +67     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@tchaton tchaton enabled auto-merge (squash) July 1, 2021 11:10
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tchaton tchaton merged commit 3e6f884 into master Jul 1, 2021
@tchaton tchaton deleted the hotfix/pin-pillow branch July 1, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants