Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update deepspeed docs, add some more information and link to streamlit #8691

Merged
merged 5 commits into from Aug 3, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Aug 3, 2021

What does this PR do?

Updates the DeepSpeed docs with reference to single file checkpointing when using ZeRO 3 + some helpful information.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@SeanNaren SeanNaren added the docs Documentation related label Aug 3, 2021
@SeanNaren SeanNaren self-assigned this Aug 3, 2021
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #8691 (a33961a) into master (a1be621) will decrease coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8691    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         167     167            
  Lines       14037   14037            
=======================================
- Hits        13008   12453   -555     
- Misses       1029    1584   +555     

docs/source/advanced/advanced_gpu.rst Outdated Show resolved Hide resolved
docs/source/advanced/advanced_gpu.rst Outdated Show resolved Hide resolved
docs/source/advanced/advanced_gpu.rst Outdated Show resolved Hide resolved
@awaelchli awaelchli added this to the v1.5 milestone Aug 3, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Aug 3, 2021
Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>
@SeanNaren SeanNaren enabled auto-merge (squash) August 3, 2021 10:44
@SeanNaren SeanNaren merged commit 49d03f8 into master Aug 3, 2021
@SeanNaren SeanNaren deleted the docs/deepspeed branch August 3, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants