Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to collate deepspeed zero 3 checkpoints #8701

Merged
merged 8 commits into from Aug 4, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Aug 3, 2021

What does this PR do?

Required for #8691, follow-up from #8397

Adds a utility as suggested by @kaushikb11 to collate deepspeed sharded checkpoints. This is nicer than pointing users to a random gist by me :)

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@SeanNaren SeanNaren added feature Is an improvement or enhancement 3rd party Related to a 3rd-party labels Aug 3, 2021
@SeanNaren SeanNaren added this to the v1.5 milestone Aug 3, 2021
@SeanNaren SeanNaren self-assigned this Aug 3, 2021
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #8701 (69072ec) into master (a1be621) will increase coverage by 0%.
The diff coverage is 94%.

@@          Coverage Diff           @@
##           master   #8701   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         167     169    +2     
  Lines       14037   14075   +38     
======================================
+ Hits        13008   13045   +37     
- Misses       1029    1030    +1     

Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SeanNaren SeanNaren enabled auto-merge (squash) August 3, 2021 16:00
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how much is it our original code?

pytorch_lightning/utilities/deepspeed.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Aug 3, 2021
@SeanNaren
Copy link
Contributor Author

how much is it our original code?

I found out you can bundle MIT/apache together under the apache licence, so i've done that and included lightning in the licence :)

@SeanNaren SeanNaren merged commit 560a5c3 into master Aug 4, 2021
@SeanNaren SeanNaren deleted the feat/collate_checkpoint branch August 4, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants