Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in macro average for a number of classification metrics #1821

Merged
merged 13 commits into from
Jun 15, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jun 3, 2023

What does this PR do?

Redo of PR #1715.

Fixes #1693
Fixes #1692
Fixes #1691
Fixes #1664

This time tests should pass. There are repetitions in the introduced code that could be refactored, but lets figure that out in a follow up PR.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭


馃摎 Documentation preview 馃摎: https://torchmetrics--1821.org.readthedocs.build/en/1821/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Jun 3, 2023
@SkafteNicki SkafteNicki added this to the v1.0.0 milestone Jun 3, 2023
@SkafteNicki SkafteNicki changed the title Bugfix/macro Fix bug in macro average for a number of classification metrics Jun 3, 2023
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #1821 (03f0729) into master (181e112) will decrease coverage by 0%.
The diff coverage is 100%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1821   +/-   ##
======================================
- Coverage      87%     87%   -0%     
======================================
  Files         254     254           
  Lines       14310   14307    -3     
======================================
- Hits        12513   12510    -3     
  Misses       1797    1797           

@mergify mergify bot added the ready label Jun 3, 2023
@mergify mergify bot requested a review from a team June 3, 2023 20:21
@Borda Borda enabled auto-merge (squash) June 12, 2023 11:43
@mergify mergify bot requested a review from stancld as a code owner June 15, 2023 12:17
@Borda Borda merged commit 17a4920 into master Jun 15, 2023
62 checks passed
@Borda Borda deleted the bugfix/macro branch June 15, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
4 participants