Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New metric: EditDistance #1906

Merged
merged 21 commits into from Jul 28, 2023
Merged

New metric: EditDistance #1906

merged 21 commits into from Jul 28, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jul 11, 2023 •
edited by github-actions bot

What does this PR do?

Fixes #937

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

📚 Documentation preview 📚: https://torchmetrics--1906.org.readthedocs.build/en/1906/

@SkafteNicki SkafteNicki added enhancement New feature or request New metric labels Jul 11, 2023
@SkafteNicki SkafteNicki added this to the v1.1.0 milestone Jul 11, 2023
@SkafteNicki SkafteNicki added this to In progress in Text via automation Jul 11, 2023
@SkafteNicki SkafteNicki marked this pull request as draft July 11, 2023 15:31
@SkafteNicki SkafteNicki marked this pull request as ready for review July 13, 2023 15:19
@codecov
Copy link

codecov bot commented Jul 17, 2023 •
edited

Codecov Report

Merging #1906 (e0db63d) into master (7fa04b5) will increase coverage by 0%.
The diff coverage is 95%.

Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #1906   +/-   ##
======================================
  Coverage      85%     85%           
======================================
  Files         263     265    +2     
  Lines       15087   15159   +72     
======================================
+ Hits        12833   12901   +68     
- Misses       2254    2258    +4

@mergify mergify bot added ready and removed ready labels Jul 17, 2023
@mergify mergify bot removed the has conflicts label Jul 25, 2023
@SkafteNicki
Copy link
Member Author

@stancld please review :]

@mergify mergify bot added the ready label Jul 25, 2023
stancld
stancld approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Text automation moved this from In progress to Reviewer approved Jul 28, 2023
@stancld stancld enabled auto-merge (squash) July 28, 2023 07:19
@stancld stancld merged commit ab74258 into master Jul 28, 2023
63 checks passed
Text automation moved this from Reviewer approved to Done Jul 28, 2023
@stancld stancld deleted the metric/edit branch July 28, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@stancld stancld stancld approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request New metric ready topic: Text
Projects
No open projects
Text
Done
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Metrics for Levenshtein edit-distance between two strings
3 participants
@SkafteNicki @Borda @stancld