Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Metric: Dunn Index #2049

Merged
merged 26 commits into from Sep 6, 2023
Merged

Conversation

matsumotosan
Copy link
Member

@matsumotosan matsumotosan commented Sep 3, 2023

What does this PR do?

Fixes part of #2003

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭


馃摎 Documentation preview 馃摎: https://torchmetrics--2049.org.readthedocs.build/en/2049/

@github-actions github-actions bot added documentation Improvements or additions to documentation topic: Cluster labels Sep 3, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
docs/source/clustering/dunn_index.rst Show resolved Hide resolved
src/torchmetrics/clustering/dunn_index.py Outdated Show resolved Hide resolved
src/torchmetrics/clustering/dunn_index.py Outdated Show resolved Hide resolved
src/torchmetrics/functional/clustering/dunn_index.py Outdated Show resolved Hide resolved
src/torchmetrics/functional/clustering/dunn_index.py Outdated Show resolved Hide resolved
src/torchmetrics/functional/clustering/dunn_index.py Outdated Show resolved Hide resolved
@SkafteNicki SkafteNicki mentioned this pull request Sep 4, 2023
13 tasks
matsumotosan and others added 2 commits September 4, 2023 22:53
* docs

* functional

* module

* tests

* changelog

* try another link

* mypy

* remove broken link

* change image

* use new inputs

* fix

* fix flaky tests

---------

Co-authored-by: Daniel Stancl <46073029+stancld@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@matsumotosan matsumotosan marked this pull request as ready for review September 4, 2023 14:26
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #2049 (43f25f2) into master (8d82db0) will increase coverage by 0%.
Report is 1 commits behind head on master.
The diff coverage is 96%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2049   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         281     283    +2     
  Lines       15886   15934   +48     
======================================
+ Hits        13784   13832   +48     
  Misses       2102    2102           

@SkafteNicki SkafteNicki added this to the v1.2.0 milestone Sep 6, 2023
@SkafteNicki SkafteNicki added this to In progress in Clustering via automation Sep 6, 2023
@mergify mergify bot added the ready label Sep 6, 2023
@SkafteNicki SkafteNicki enabled auto-merge (squash) September 6, 2023 10:02
src/torchmetrics/functional/clustering/utils.py Outdated Show resolved Hide resolved
tests/unittests/clustering/test_dunn_index.py Outdated Show resolved Hide resolved
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
auto-merge was automatically disabled September 6, 2023 12:53

Head branch was pushed to by a user without write access

@justusschock justusschock enabled auto-merge (squash) September 6, 2023 14:27
@justusschock justusschock merged commit 163b0aa into Lightning-AI:master Sep 6, 2023
66 checks passed
Clustering automation moved this from In progress to Done Sep 6, 2023
@matsumotosan matsumotosan deleted the 2003-dunn-index branch September 7, 2023 05:00
matsumotosan added a commit to matsumotosan/metrics that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation New metric ready topic: Cluster
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants