Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress warning for running metric wrapper #2265

Merged
merged 6 commits into from Dec 20, 2023
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Dec 9, 2023

What does this PR do?

Fixes #2264
Because we make use of .reset in the runner wrapper it leads to a warning being raised, but everything is completely fine.
PR fixes this.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭


馃摎 Documentation preview 馃摎: https://torchmetrics--2265.org.readthedocs.build/en/2265/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Dec 9, 2023
@SkafteNicki SkafteNicki added this to the v1.2.x milestone Dec 9, 2023
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #2265 (3d61e23) into master (c5a9a69) will increase coverage by 0%.
The diff coverage is 100%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2265   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         294     294           
  Lines       16627   16628    +1     
======================================
+ Hits        14436   14437    +1     
  Misses       2191    2191           

@mergify mergify bot added the ready label Dec 10, 2023
@Borda Borda merged commit 379eecc into master Dec 20, 2023
28 of 37 checks passed
@Borda Borda deleted the no_warning_for_running branch December 20, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive warning about calling compute() before update()
3 participants