Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new metric "quality with no reference" #2288

Merged

Conversation

ywchan2005
Copy link
Contributor

@ywchan2005 ywchan2005 commented Dec 31, 2023

What does this PR do?

Add new metric 'QNR' (quality with no reference)
(being part of #799 )

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2288.org.readthedocs.build/en/2288/

@github-actions github-actions bot added documentation Improvements or additions to documentation topic: Image labels Dec 31, 2023
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Merging #2288 (9b0d153) into master (321a7a1) will increase coverage by 0%.
The diff coverage is 80%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2288   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         303     305    +2     
  Lines       17058   17148   +90     
======================================
+ Hits        11760   11832   +72     
- Misses       5298    5316   +18     

@stancld stancld mentioned this pull request Jan 1, 2024
src/torchmetrics/image/qnr.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label Jan 4, 2024
ywchan2005 and others added 2 commits January 4, 2024 23:37
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good already. few minor comments

src/torchmetrics/functional/image/qnr.py Show resolved Hide resolved
src/torchmetrics/image/qnr.py Outdated Show resolved Hide resolved
src/torchmetrics/image/qnr.py Show resolved Hide resolved
src/torchmetrics/image/qnr.py Show resolved Hide resolved
@mergify mergify bot removed the ready label Jan 21, 2024
@SkafteNicki SkafteNicki added this to the v1.4.0 milestone Jan 29, 2024
src/torchmetrics/functional/image/qnr.py Outdated Show resolved Hide resolved
src/torchmetrics/image/qnr.py Show resolved Hide resolved
@mergify mergify bot added ready and removed ready labels Jan 30, 2024
@Borda Borda enabled auto-merge (squash) February 6, 2024 13:16
@mergify mergify bot added the ready label Feb 6, 2024
@Borda Borda merged commit 764d4fa into Lightning-AI:master Feb 7, 2024
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation New metric ready topic: Image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants