Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map second fix empty preds #610

Merged
merged 19 commits into from Nov 8, 2021
Merged

Map second fix empty preds #610

merged 19 commits into from Nov 8, 2021

Conversation

tkupek
Copy link
Contributor

@tkupek tkupek commented Nov 8, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Does the same as #594 but fixes an issue, where we only check if the first prediction is empty and not the full list.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

tobias-kupek-swarm and others added 18 commits October 29, 2021 21:54
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #610 (dce9163) into master (fef83a0) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #610   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         150    150           
  Lines        5308   5308           
=====================================
- Hits         5050   5048    -2     
- Misses        258    260    +2     

@Borda Borda added the bug / fix Something isn't working label Nov 8, 2021
@SkafteNicki SkafteNicki enabled auto-merge (squash) November 8, 2021 13:35
@SkafteNicki SkafteNicki merged commit 7161bb6 into Lightning-AI:master Nov 8, 2021
@mergify mergify bot added the ready label Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants