Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-Tuning Scheduler Tutorial Update for Lightning/PyTorch 2.2.0 #298

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

speediedan
Copy link
Contributor

Validated the Fine-Tuning Scheduler (FTS) tutorial for FTS/Lightning/PyTorch 2.2.0 (as of the final PyTorch RC and the recent 2.2.0 Lightning commit).

The only minor change in this PR is to remove references/links to tensorboard.dev since that service is shutting down on 2023.12.31.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Updates the Fine-Tuning Scheduler tutorial to prepare for 2.2.0 tutorial publishing.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from Borda December 27, 2023 20:30
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70%. Comparing base (684b63b) to head (2efc41a).

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #298   +/-   ##
===================================
  Coverage    70%    70%           
===================================
  Files         2      2           
  Lines       435    435           
===================================
  Hits        303    303           
  Misses      132    132           

@speediedan speediedan marked this pull request as ready for review December 27, 2023 20:41
@speediedan
Copy link
Contributor Author

Note only error is a link resolution error unrelated to this PR or tutorial.

@Borda Borda force-pushed the main branch 2 times, most recently from d4acf6f to ac8f7ba Compare July 19, 2024 21:12
@Borda
Copy link
Member

Borda commented Jul 23, 2024

@speediedan apology for the long delay but finally got the repo work again...

@Borda Borda enabled auto-merge (squash) July 26, 2024 07:15
@Borda Borda merged commit 910c12d into Lightning-AI:main Jul 26, 2024
15 checks passed
@speediedan
Copy link
Contributor Author

@speediedan apology for the long delay but finally got the repo work again...

@Borda Thanks for streamlining the tutorials publishing process and fixing the outstanding issues! Love the simplification dropping the largely duplicative nbval part of the flow. Thanks again for all your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants