Skip to content

Commit

Permalink
ci: enable setting python version for package build (#244)
Browse files Browse the repository at this point in the history
* enable setting python version for package build
* chlog + test
* Description...
  • Loading branch information
Borda committed Mar 25, 2024
1 parent a2c03eb commit 19332de
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/check-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@ on:
required: false
default: ""
build-matrix:
description: "what building configs in json format"
description: "what building configs in json format, expected keys are `os` and `python-version`"
required: false
type: string
default: |
{
"os": ["ubuntu-latest"],
}
testing-matrix:
description: "what test configs to run in json format"
description: "what test configs to run in json format, expected keys are `os` and `python-version`"
required: false
type: string
# default operating systems should be pinned to specific versions instead of "-latest" for stability
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
- name: Set up Python 🐍
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: ${{ matrix.python-version || '3.x' }}

- name: Pull reusable 🤖 actions️
uses: actions/checkout@v4
Expand Down Expand Up @@ -113,7 +113,7 @@ jobs:
- name: Set up Python 🐍 ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
python-version: ${{ matrix.python-version || '3.x' }}

- name: Pull reusable 🤖 actions️
uses: actions/checkout@v4
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/ci-use-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ jobs:
actions-ref: ${{ github.sha }} # use local version
artifact-name: dist-packages-${{ github.sha }}
import-name: "lightning_utilities"
build-matrix: |
{
"os": ["ubuntu-22.04"],
"python-version": ["3.10"]
}
testing-matrix: |
{
"os": ["ubuntu-22.04", "macos-12", "windows-2022"],
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

-
- CI: enable setting python version for package build ([#244](https://github.com/Lightning-AI/utilities/pull/244))


### Deprecated
Expand Down

0 comments on commit 19332de

Please sign in to comment.