Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruff: C4-PT-RET-SIM #117

Merged
merged 3 commits into from
Mar 6, 2023
Merged

ruff: C4-PT-RET-SIM #117

merged 3 commits into from
Mar 6, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 6, 2023

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pas locally?

What does this PR do?

improve code health

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

@Borda Borda added the enhancement New feature or request label Mar 6, 2023
@Borda Borda enabled auto-merge (squash) March 6, 2023 14:15
@Borda Borda merged commit c01bf05 into main Mar 6, 2023
@Borda Borda deleted the ruff/C4-PT-RET-SIM branch March 6, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@akihironitta akihironitta Awaiting requested review from akihironitta

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borda @carmocca