Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for imports when optional packages are unavailable #428

Merged
merged 53 commits into from
Aug 13, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Dec 7, 2020

What does this PR do?

Fixes #421.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@akihironitta akihironitta added the ci/cd Continues Integration and delivery label Dec 7, 2020
@akihironitta akihironitta added this to In progress in Code Health / Refatoring via automation Dec 7, 2020
@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #428 (b358569) into master (5ab4fae) will decrease coverage by 47.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #428       +/-   ##
===========================================
- Coverage   72.01%   24.83%   -47.18%     
===========================================
  Files         119      119               
  Lines        7367     7332       -35     
===========================================
- Hits         5305     1821     -3484     
- Misses       2062     5511     +3449     
Flag Coverage Δ
cpu 24.83% <ø> (-47.18%) ⬇️
pytest 24.83% <ø> (-47.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/models/rl/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
pl_bolts/models/rl/common/agents.py 0.00% <0.00%> (-100.00%) ⬇️
pl_bolts/models/rl/dueling_dqn_model.py 0.00% <0.00%> (-100.00%) ⬇️
pl_bolts/models/rl/double_dqn_model.py 0.00% <0.00%> (-95.84%) ⬇️
...l_bolts/models/rl/vanilla_policy_gradient_model.py 0.00% <0.00%> (-93.45%) ⬇️
pl_bolts/models/rl/common/networks.py 0.00% <0.00%> (-91.60%) ⬇️
pl_bolts/models/rl/reinforce_model.py 0.00% <0.00%> (-89.40%) ⬇️
pl_bolts/models/rl/per_dqn_model.py 0.00% <0.00%> (-86.89%) ⬇️
pl_bolts/models/rl/ppo_model.py 0.00% <0.00%> (-86.82%) ⬇️
pl_bolts/models/rl/common/gym_wrappers.py 0.00% <0.00%> (-85.50%) ⬇️
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ab4fae...b358569. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Dec 7, 2020

Hello @akihironitta! Thanks for updating this PR.

Line 7:2: W292 no newline at end of file

Line 1:114: W292 no newline at end of file

Comment last updated at 2021-06-24 02:35:00 UTC

@Borda
Copy link
Member

Borda commented Jan 2, 2021

@akihironitta what is missing to finish it, mind update the description with linking the partial PRs?

@akihironitta
Copy link
Contributor Author

I completely forgot about this PR. I'll quickly make this PR ready for review!

mind update the description with linking the partial PRs?

Actually, all tests for optional imports are being added in this PR because I thought it's quite easy to review at once... I'll split this PR into several PRs if you'd like :]

@akihironitta akihironitta added this to the v0.4 milestone May 6, 2021
@Borda
Copy link
Member

Borda commented Jun 17, 2021

Sorry, the actual change was unclear. Please see only the change in .github/workflows/ci_test-full.yml.

can you pls make it the only change of this PR?

@akihironitta
Copy link
Contributor Author

Sorry, the actual change was unclear. Please see only the change in .github/workflows/ci_test-full.yml.

can you pls make it the only change of this PR?

@Borda Could you have another look?

@Borda Borda disabled auto-merge August 13, 2021 12:32
@Borda Borda merged commit fb558d1 into Lightning-Universe:master Aug 13, 2021
Code Health / Refatoring automation moved this from in Review to Done Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Continues Integration and delivery ready
Development

Successfully merging this pull request may close these issues.

Test importing when optional packages are unavailable
4 participants